[Point of Contact] Phone Extension - Limit to 9 digits, 0-9 in string #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shindigira
requested review from
billhimmelsbach,
meissadia,
ojbravo and
tanner-ricks
as code owners
shindigira
changed the title
…ntend into 997-phone-extension-9-digit
meissadia
pushed a commit
that referenced
this pull request
Oct 21, 2024
…#1001) closes #997 ## Changes - style(Point of Contact): Phone Extension always gets its own line - content(Point of Contact): Change the helper and error text to match the figma - feat(Point of Contact): Phone Extension validation ## How to test this PR 1. Navigate to Point of Contact 2. Enter valid phone extension - ex. 00757 3. Enter invalid phone extension - ex ukhi778ih89h98h9h9h89h ## Screenshots <img width="534" alt="Screenshot 2024-10-15 at 3 08 40 PM" src="https://github.com/user-attachments/assets/7ed7bae8-9bc0-489f-9e63-a7748e8b9582"> --------- Co-authored-by: Tanner Ricks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #997
Changes
How to test this PR
Screenshots