Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Make tests runnable against dev #1043

Merged
merged 10 commits into from
Nov 8, 2024
Merged

[e2e] Make tests runnable against dev #1043

merged 10 commits into from
Nov 8, 2024

Conversation

tanner-ricks
Copy link
Contributor

@tanner-ricks tanner-ricks commented Nov 1, 2024

Made e2e test suite runnable against the dev deployment when running locally.

Changes

  • Added calls to cleanup logic after tests
  • Added code to change the way auth works when running against dev
  • Added additional environment variables that were missed before
  • Fixed certificate issue causing the tests to run against dev

How to test this PR

  1. Read the notes
  2. Make sure all other repos are up to date
  3. Pull the branch for the sbl-frontend repo
  4. Update your local .env file to reflect what is in the .env.example file
  5. Comment out and override the following values in your local .env with what is listed below replacing the placeholder values with their appropriate ones:
    • SBL_PLAYWRIGHT_TEST_TARGET="<FRONTEND_URL>"
    • SBL_PLAYWRIGHT_TEST_REGTECH_TARGET="<USER_FI_URL>"
    • SBL_PLAYWRIGHT_TEST_FILING_TARGET="<FILING_URL>"
    • SBL_PLAYWRIGHT_TEST_MAIL_TARGET="<MAIL_URL>"
    • SBL_PLAYWRIGHT_TEST_CLEANUP_TARGET="<CLEANUP_URL>"
    • SBL_PLAYWRIGHT_TEST_KC_TARGET="<KEYCLOAK_URL>"
    • SBL_PLAYWRIGHT_TEST_KC_CLI_CLIENT_SECRET="<KEYCLOAK_SECRET>"

Notes

  • As long as dev is out of date and the tests have been updated then it is to be expected that you will see failures when running against dev.
  • As it stands at the time of this writing, there are test failures related to dev being out of date.

@tanner-ricks tanner-ricks linked an issue Nov 1, 2024 that may be closed by this pull request
@tanner-ricks tanner-ricks marked this pull request as draft November 4, 2024 16:58
@tanner-ricks tanner-ricks changed the title [e2e] Make tests runnable against dev Draft: [e2e] Make tests runnable against dev Nov 4, 2024
@tanner-ricks tanner-ricks changed the title Draft: [e2e] Make tests runnable against dev [e2e] Make tests runnable against dev Nov 4, 2024
@tanner-ricks tanner-ricks marked this pull request as ready for review November 4, 2024 17:47
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great! I had a few comments. Has the migration affected the certs at all?

.github/workflows/test.yml Outdated Show resolved Hide resolved
ENV-GUIDE.md Show resolved Hide resolved
ENV-GUIDE.md Show resolved Hide resolved
e2e/certs/entrust_chain.cer Outdated Show resolved Hide resolved
@billhimmelsbach
Copy link
Contributor

Jason is going to work on a fix for the cleanup-api, then this should be good to go.

Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks for fixing that issue with the Complete user profile page test! Mind making a ticket for reenabling the error?

@tanner-ricks tanner-ricks merged commit 4195baf into main Nov 8, 2024
10 checks passed
@tanner-ricks tanner-ricks deleted the 1042-e2e-dev-tests branch November 8, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Make tests runnable against dev
2 participants