Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of RegExp #1051

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Remove usage of RegExp #1051

wants to merge 6 commits into from

Conversation

meissadia
Copy link
Collaborator

Close #1049

Eliminates use of RegExp so that we don't need to rely on the recheck library (which can be quite slow to run) to ensure we remain in the safe zone.

Changes

  • Eliminates unused code that used RegExp
  • Replaces RegExp usage with plain string functions

How to test this PR

  1. Since this has the potential to affect every link on the site, I would like to hold off on moving this forward until we implement image diff testing via Playwright to make it easier to identify any breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach will be requested when the pull request is marked ready for review billhimmelsbach is a code owner

@tanner-ricks tanner-ricks Awaiting requested review from tanner-ricks tanner-ricks will be requested when the pull request is marked ready for review tanner-ricks is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Security) Integrate recheck for RegExps
1 participant
@meissadia