Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to align with the aead-properties draft #30

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Try to align with the aead-properties draft #30

merged 5 commits into from
Jan 17, 2024

Conversation

jedisct1
Copy link
Collaborator

@jedisct1 jedisct1 commented Jan 15, 2024

Fixes #29

@jedisct1
Copy link
Collaborator Author

@samuel-lucas6 Do you think you could review this these changes this week? It would be good to start the RGLC process soon.

@samuel-lucas6
Copy link
Collaborator

@samuel-lucas6 Do you think you could review this these changes this week? It would be good to start the RGLC process soon.

Yep, I'll have a look in a minute. I was planning to do this PR but didn't get around to it.

Copy link
Collaborator

@samuel-lucas6 samuel-lucas6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some feedback/points of discussion.

draft-irtf-cfrg-aegis-aead.md Show resolved Hide resolved
draft-irtf-cfrg-aegis-aead.md Outdated Show resolved Hide resolved
draft-irtf-cfrg-aegis-aead.md Outdated Show resolved Hide resolved
draft-irtf-cfrg-aegis-aead.md Show resolved Hide resolved
draft-irtf-cfrg-aegis-aead.md Outdated Show resolved Hide resolved
draft-irtf-cfrg-aegis-aead.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@samuel-lucas6 samuel-lucas6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jedisct1 jedisct1 merged commit 43dae76 into main Jan 17, 2024
2 checks passed
@jedisct1 jedisct1 deleted the alignment branch January 17, 2024 21:29
jedisct1 added a commit that referenced this pull request Jan 20, 2024
An attempt to address #31 - depends on #30

Paragraphs have just been reordered in order to fit into 5 subsections.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment with draft-irtf-cfrg-aead-properties
2 participants