Cancellation Message Types #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamJaarsma
reviewed
Oct 31, 2024
| // Response header | ||
| cmp.types.v1.ResponseHeader header = 1; | ||
|
|
||
| // Accept counter cancellation transaction ID |
There was a problem hiding this comment.
Suggested change
| // Accept counter cancellation transaction ID | |
| // Accept counter cancellation on-chain transaction ID for registration of the event to avoid disputes |
SamJaarsma
reviewed
Oct 31, 2024
| // Response header | ||
| cmp.types.v1.ResponseHeader header = 1; | ||
|
|
||
| // Accept cancellation transaction ID |
There was a problem hiding this comment.
Suggested change
| // Accept cancellation transaction ID | |
| // Accept counter cancellation on-chain transaction ID for registration of the event to avoid disputes |
SamJaarsma
reviewed
Oct 31, 2024
| // Response Header | ||
| cmp.types.v1.ResponseHeader header = 1; | ||
|
|
||
| // Transaction id for the rejected cancellation |
There was a problem hiding this comment.
Suggested change
| // Transaction id for the rejected cancellation | |
| // On-chain transaction id for the rejected cancellation for registration of the event to avoid disputes |
SamJaarsma
reviewed
Oct 31, 2024
|
|
||
| // The amount to be refunded | ||
| cmp.types.v2.Price refund_amount = 3; | ||
| } |
There was a problem hiding this comment.
add field with enum for cancellation reason
SamJaarsma
reviewed
Oct 31, 2024
|
|
||
| // Cancellation token ID | ||
| uint64 token_id = 2; | ||
| } |
There was a problem hiding this comment.
add reason to cancel the cancellation with an enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
buf.yaml
ignore_onlylint configuration to includeproto/cmp/services/notification/v2/notify.protounderRPC_REQUEST_STANDARD_NAME. (To allow empty responses for the notification endpoints)Cancellation Service Protos:
.protofiles for handling various aspects of cancellation services withinproto/cmp/services/cancellation/v1/:accept.proto: DefinesAcceptCancellationRequestandAcceptCancellationResponsemessages for accepting cancellation requests.accept_counter.proto: DefinesAcceptCounterCancellationRequestandAcceptCounterCancellationResponsemessages for accepting countered cancellations.cancel_proposal.proto: DefinesCancelCancellationRequestandCancelCancellationResponsefor active cancellation proposal cancellations.counter.proto: DefinesCounterCancellationRequestandCounterCancellationResponsefor countering cancellations.initiate.proto: DefinesInitiateCancellationRequestandInitiateCancellationResponsefor initiating cancellation requests.reject.proto: DefinesRejectCancellationRequestandRejectCancellationResponsewith a detailedCancellationRejectionReasonenum to cover various rejection scenarios.check.proto: DefinesCheckCancellationRequest,CheckCancellationResponseand the relatedCheckCancellationService.services.protofile underv1includes theCancellationService, which unifies the above functionalities under defined RPC methods.Notification Service Updates:
proto/cmp/services/notification/v1/notify.protowith a diagram link for service documentation.NotificationServiceversion underproto/cmp/services/notification/v2/notify.prototo expand notification events related to cancellation:CancellationPendingCancellationAcceptedCancellationProposalAcceptedByTheOwnerCancellationCounteredCancellationProposalCancelledCancellationRejected