Change bitcoin library to tapyrus #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yamaguchi
force-pushed
the
change_tapyrus_to_bitcoin
branch
from
0014366 to
a5a7bbe
Compare
Yamaguchi
force-pushed
the
change_tapyrus_to_bitcoin
branch
from
a5a7bbe to
9bdba76
Compare
Yamaguchi
commented
Jun 25, 2024
| @@ -659,9 +663,9 @@ mod test { | |||
| let async_res = async_client.broadcast(tx.as_ref().unwrap()).await; | |||
| let blocking_res = blocking_client.broadcast(tx.as_ref().unwrap()); | |||
| assert!(async_res.is_err()); | |||
| assert_eq!(async_res.unwrap_err().to_string(),"HttpResponse { status: 400, message: \"sendrawtransaction RPC error: {\\\"code\\\":-27,\\\"message\\\":\\\"Transaction already in block chain\\\"}\" }"); | |||
| assert_eq!(async_res.unwrap_err().to_string(),"HttpResponse { status: 400, message: \"sendrawtransaction RPC error: {\\\"code\\\":-27,\\\"message\\\":\\\"transaction already in block chain\\\"}\" }"); | |||
There was a problem hiding this comment.
現状、TapyrusCoreが返すメッセージが小文字で始まるためそれに合わせてます。
Yamaguchi
commented
Jun 25, 2024
src/lib.rs
Outdated
| @@ -505,19 +505,20 @@ mod test { | |||
|
|
|||
| #[cfg(all(feature = "blocking", feature = "async"))] | |||
| #[tokio::test] | |||
| #[ignore] | |||
There was a problem hiding this comment.
TapyrusCoreが返すRPC gettransaction のレスポンスにblockheightが含まれないためこのテストは失敗します。いったんIgnoreにしました。
Yamaguchi
commented
Jun 25, 2024
src/lib.rs
Outdated
| @@ -903,9 +907,10 @@ mod test { | |||
|
|
|||
| #[cfg(all(feature = "blocking", feature = "async"))] | |||
| #[tokio::test] | |||
| #[ignore] | |||
There was a problem hiding this comment.
esploraのGET /blocks
のレスポンスのフォーマットがesplora-tapyrusとesplora(bitcoin)で異なる(timestampフィールドが無い)ためこのテストは失敗します。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.