Change bitcoin library to tapyrus #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yamaguchi
force-pushed
the
use_rust_tapyrus
branch
2 times, most recently
from
fbfb96f to
5c258a3
Compare
Yamaguchi
force-pushed
the
use_rust_tapyrus
branch
from
5c258a3 to
5db96e6
Compare
Yamaguchi
commented
Jun 21, 2024
| @@ -125,20 +102,20 @@ mod download { | |||
| }; | |||
|
|
|||
| let tarball_hash = sha256::Hash::hash(&tarball_bytes); | |||
There was a problem hiding this comment.
リリースされているtarballのsha256値を検証する箇所はスキップしてます。
Yamaguchi
commented
Jun 21, 2024
| @@ -270,7 +287,9 @@ impl BitcoinD { | |||
|
|
|||
| let work_dir_path = work_dir.path(); | |||
| debug!("work_dir: {:?}", work_dir_path); | |||
| let cookie_file = work_dir_path.join(conf.network).join(".cookie"); | |||
| let cookie_file = work_dir_path | |||
There was a problem hiding this comment.
cookieファイルの生成場所を変更
<Tapyrusのデータディレクトリ>/regtest/.cookie => <Tapyrusのデータディレクトリ>/dev-(ネットワークID)/.cookie
Yamaguchi
commented
Jun 21, 2024
| "launching {:?} with args: {:?} {:?} AND custom args: {:?}", | ||
| exe.as_ref(), | ||
| default_args, | ||
| p2p_args, | ||
| conf_args | ||
| ); | ||
|
|
||
| File::create(format!( |
Yamaguchi
commented
Jun 21, 2024
| assert_eq!(1, info.blocks); | ||
| } | ||
|
|
||
| #[test] | ||
| #[cfg(feature = "0_21_2")] | ||
| #[ignore] |
There was a problem hiding this comment.
getindexinfoはtapyrusでは未実装
Yamaguchi
commented
Jun 21, 2024
| #[test] | ||
| #[ignore] |
There was a problem hiding this comment.
getbalancesはtapyrusでは未実装
Yamaguchi
force-pushed
the
use_rust_tapyrus
branch
from
5db96e6 to
57f5a6c
Compare
Yamaguchi
force-pushed
the
use_rust_tapyrus
branch
from
57f5a6c to
d9f9cfb
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see chaintope/tdk#8