You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While functions like get_anndata can accept values for the organism argument like "Homo sapiens" or "homo_sapiens", functions in the embedding API only accept snake-case values like "homo_sapiens".
File ~/github/cellxgene-census/api/python/cellxgene_census/src/cellxgene_census/experimental/_embedding.py:207, in get_embedding_metadata_by_name(embedding_name, organism, census_version, embedding_type)
204 embeddings.append(obj)
206iflen(embeddings) ==0:
--> 207 raise ValueError(f"No embeddings found for {embedding_name}, {organism}, {resolved_census_version}, {embedding_type}")
209returnsorted(embeddings, key=lambdax: x["submission_date"])[-1]
ValueError: No embeddings found for scvi, Homo sapiens, 2023-12-15, obs_embedding
Expected behavior
The accepted values and behavior of the organism argument to be consistent across functions.
Environment
Provide a description of your system and the software versions.
Describe the bug
While functions like
get_anndata
can accept values for theorganism
argument like"Homo sapiens"
or"homo_sapiens"
, functions in the embedding API only accept snake-case values like"homo_sapiens"
.To Reproduce
Both of these work:
For the embeddings, this works:
But this doesn't:
Expected behavior
The accepted values and behavior of the
organism
argument to be consistent across functions.Environment
Provide a description of your system and the software versions.
Additional context
Some previous discussion:
organism
ofcellxgene_census._get_experiment
/cellxgene.census::get_experiment
should allow computer readable strings: "homo_sapiens" and "mus_musculus" #646The text was updated successfully, but these errors were encountered: