Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_dataset_presence_matrix should include genes with 0 counts #1284

Open
ebezzi opened this issue Sep 20, 2024 · 3 comments
Open

feature_dataset_presence_matrix should include genes with 0 counts #1284

ebezzi opened this issue Sep 20, 2024 · 3 comments
Labels
bug Something isn't working census builder Related to the census builder tool

Comments

@ebezzi
Copy link
Member

ebezzi commented Sep 20, 2024

Describe the bug

The current feature_dataset_presence_matrix only reports genes that have a total expression count > 0. Instead, it should report all genes that were listed in the original dataset.

To Reproduce

For dataset 0895c838-e550-48a3-a777-dbcd35d30272, 13696 genes are nnz

Expected behavior

For dataset 0895c838-e550-48a3-a777-dbcd35d30272, 33363 should be nnz

@ebezzi ebezzi added the bug Something isn't working label Sep 20, 2024
@ivirshup ivirshup assigned ivirshup and unassigned ivirshup Sep 23, 2024
@ivirshup ivirshup added the census builder Related to the census builder tool label Sep 23, 2024
@ivirshup
Copy link
Collaborator

How big of a bug is this? Does it need to be fixed in the LTS?

@ebezzi
Copy link
Member Author

ebezzi commented Sep 23, 2024

Don't think it's worth an errata.

@giovp
Copy link

giovp commented Oct 28, 2024

The current feature_dataset_presence_matrix only reports genes that have a total expression count > 0. Instead, it should report all genes that were listed in the original dataset.

I'm not sure if this is the correct issue that we were discussing @ivirshup , but I wonder if both information should be present

  • nnz: genes with expression > 0
  • : genes that were part of the original submision (e.g. the gene universe for that dataset).

on the latter, is there a check during submission, that checks that all genes submitted have at least one count in any of the cells in the dataset? just wondering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working census builder Related to the census builder tool
Projects
None yet
Development

No branches or pull requests

3 participants