Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Galago domain #1712

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Change Galago domain #1712

merged 2 commits into from
Oct 29, 2024

Conversation

vincent-czi
Copy link
Contributor

Summary:

App code changes for Galago moving to new domain.

IMPORTANT: Do NOT just merge and deploy. This change must be deployed to Prod at the same time we update the GitHub Pages custom URL for Galago. I believe all the CZI infra stuff is in place for the making the GitHub Pages change, but GitHub Pages change AND the deployed app code must change for the Galago link out to work correctly. If only one of those is done but not the other, the link out will break until the other is completed.

Context:

With the hand-off to Theiagen, we're moving Galago to a new domain. It currently lives at galago.czgenepi.org, but since we're basically sunsetting that domain, we need to move it. It will now live as a sub-domain under CZI Science at galago.cziscience.com. Since Galago is entirely browser-based, we do not serve it via AWS like most of our other CZI apps. Instead, it lives as a GitHub Page with a custom domain. I've worked with CZI Central to set up the appropriate records so GitHub Pages can use the new domain. However, because GitHub Pages only supports a single custom domain at a time, we have to switch the custom domain setting at the same time we deploy this app code. Nothing breaks permanently if they don't deploy simultaneously, but the Galago link out will be broken until both aspects are complete.

Once this PR is merged and deployed to Staging, the Galago link out will be broken there. I'll then coordinate with Central to make sure we're ready to switch over, do a Prod deploy, and change the GitHub Pages custom domain setting at the same time.

@vincent-czi vincent-czi added frontend Involves changes to frontend code backend Involves changes to backend code ez-pz Quick and easy to review labels Oct 29, 2024
"""
allowed_origins = [
"https://galago.czgenepi.org",
"https://galago-labs.czgenepi.org",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

galago-labs was the Staging env for Galago. For ease, it was just its own repo with its own GitHub Page. Since Galago isn't under active development, we haven't set up any of the custom domain stuff for galago-labs it, and I'm removing it here.

@vincent-czi vincent-czi merged commit 597e7da into trunk Oct 29, 2024
13 checks passed
@vincent-czi vincent-czi deleted the vince/galago-new-domain branch October 29, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Involves changes to backend code ez-pz Quick and easy to review frontend Involves changes to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants