Dyno: fix nested type queries #26693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Danila Fedorin <[email protected]>
benharsh
approved these changes
Feb 14, 2025
| @@ -1254,6 +1254,16 @@ bool canInstantiateSubstitutions(Context* context, | |||
| auto r = canPass(context, mySubType, pSubType); | |||
| if (r.passes() && !r.promotes() && !r.converts()) { | |||
| // instantiation and same-type passing are allowed here | |||
| // | |||
| // canPass doesn't check param values for equivalence to allow handling | |||
| // coerciions and narrowing, so explicitly check them here. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Cray/chapel-private/issues/6474.
This seemed to be a problem to do with partial instantiations of types. We only handled passing (partially) instantiated class types to fully generic formals. This PR changes this by sharing the instantiation logic between record types and class types, and fixing a minor issue about (incompatible) param instantiations.
Testing