Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mason test not working when make install is used #26698

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Feb 12, 2025

Fixes an issue where mason was using the wrong CHPL_HOME path.

Previously, mason relied on a CHPL_HOME embedded in the binary. This was used to run tests via mason test. However, with make install CHPL_HOME would be different at build time versus install time.

This PR resolves the issue by having mason use the following for CHPL_HOME.

  1. if the env var CHPL_HOME is set, use that
  2. if chpl is available in PATH, use the CHPL_HOME from that (as reported by --print-chpl-home)
  3. otherwise, fallback to the previous CHPL_HOME definition (from ChplConfig).

This PR also adds a step to our packaging configs to exercise mason test to ensure it continues to work.

Resolves #25356

[Reviewed by @benharsh]

@jabraham17 jabraham17 merged commit 30002fa into chapel-lang:main Feb 12, 2025
9 checks passed
@jabraham17 jabraham17 deleted the fix-mason-test branch February 12, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: make install installs a mason with incorrect paths
2 participants