Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run workflow on Ubuntu, Windows and macOS #470

Closed

Conversation

russellbanks
Copy link
Contributor

@russellbanks russellbanks commented Sep 27, 2023

This runs the build workflow on ubuntu-latest, windows-latest, and macos-latest. fail-fast is set to false so that if the build fails on one operating system the others will not stop.

The release steps will only run on Ubuntu as to not create and release the binaries multiple times. This will need to changed (along with some changes to the build file) in #458 after this PR so that native binaries can be built and released without causing duplicate binaries. Kotlin has documentation on this.

@russellbanks
Copy link
Contributor Author

This workflow fails on Windows because rm -rf (which is done to delete caches) isn't a command on Windows.

Merging #468 will resolve this.

Copy link
Owner

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please split the assemble and publish steps out to their own job that waits on the build jobs to complete? Otherwise, as this stands, there's a risk that we'll publish a release while the Windows or macOS builds are failing.

Copy link

stale bot commented Nov 30, 2023

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. It will automatically be closed if no further activity occurs in the next seven days to enable maintainers to focus on the most important issues.
If this issue is still affecting you, please comment below within the next seven days.
Thank you for your contributions.

@stale stale bot added the stale label Nov 30, 2023
Copy link

stale bot commented Dec 7, 2023

This issue has been automatically closed because it has not had any recent activity.

@stale stale bot closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants