Warning: invalid resolution fix.

[tdhintz]

Fix for #397

[charlesw]

Thanks, I'll have a look at merging this into the dev branch later this week and do a new release (time permitting).

…

On Sat., 10 Mar. 2018, 00:43 Hintz, ***@***.***> wrote: Fix for #397 <#397> ------------------------------ You can view, comment on, or merge this pull request online at: #399 Commit Summary - Set pix resolution. - Set pix resolution. File Changes - *M* src/Tesseract/BitmapToPixConverter.cs <https://github.com/charlesw/tesseract/pull/399/files#diff-0> (6) - *M* src/Tesseract/Pix.cs <https://github.com/charlesw/tesseract/pull/399/files#diff-1> (18) Patch Links: - https://github.com/charlesw/tesseract/pull/399.patch - https://github.com/charlesw/tesseract/pull/399.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#399>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPzyA2aNprgkzZZ-IJYwXm1lC0k4Zonks5tcobhgaJpZM4SkR7n> .

[Shazter]

I'm a beginner, but the fix doesnt work for me, because Bitmap is unknown in PIX.cs. For Net Standard 2.0 compability I made this:

Changes Pix.cs:

public static Pix Create(int width, int height, int depth, int xres, int yres)
       {
           if (!AllowedDepths.Contains(depth))
               throw new ArgumentException("Depth must be 1, 2, 4, 8, 16, or 32 bits.", "depth");

           if (width <= 0) throw new ArgumentException("Width must be greater than zero", "width");
           if (height <= 0) throw new ArgumentException("Height must be greater than zero", "height");

           var handle = Interop.LeptonicaApi.Native.pixCreate(width, height, depth);
           if (handle == IntPtr.Zero) throw new InvalidOperationException("Failed to create pix, this normally occurs because the requested image size is too large, please check Standard Error Output.");
           var pix = Create(handle);
           Interop.LeptonicaApi.Native.pixSetResolution(pix.Handle, xres, yres);

           return pix;
       }

Changes BitmapToPixConverter.cs:

public Pix Convert(Bitmap img)
        {
            var pixDepth = GetPixDepth(img.PixelFormat);
            var xres = (int)img.HorizontalResolution;
            var yres = (int)img.VerticalResolution;
            var pix = Pix.Create(img.Width, img.Height, pixDepth, xres,yres);
           
            BitmapData imgData = null;
            PixData pixData = null;
            try
            { 

                if ((img.PixelFormat & PixelFormat.Indexed) == PixelFormat.Indexed) {
                    CopyColormap(img, pix);
                }

                // transfer data
                imgData = img.LockBits(new Rectangle(0, 0, img.Width, img.Height), ImageLockMode.ReadOnly, img.PixelFormat);
                pixData = pix.GetData();

                if (imgData.PixelFormat == PixelFormat.Format32bppArgb) {
                    TransferDataFormat32bppArgb(imgData, pixData);
                } else if (imgData.PixelFormat == PixelFormat.Format24bppRgb) {
                    TransferDataFormat24bppRgb(imgData, pixData);
                } else if (imgData.PixelFormat == PixelFormat.Format8bppIndexed) {
                    TransferDataFormat8bppIndexed(imgData, pixData);
                } else if (imgData.PixelFormat == PixelFormat.Format1bppIndexed) {
                    TransferDataFormat1bppIndexed(imgData, pixData);
                }
                return pix;
            } catch (Exception) {
                pix.Dispose();
                throw;
            } finally {
                if (imgData != null) {
                    img.UnlockBits(imgData);
                }
            }
        }

[Shazter]

Converting issue between float and int.

Fixed:

public Pix Convert(Bitmap img)
        {
            var pixDepth = GetPixDepth(img.PixelFormat);
            var xres = Convert.ToInt32(img.HorizontalResolution);
            var yres = Convert.ToInt32(img.VerticalResolution);
            var pix = Pix.Create(img.Width, img.Height, pixDepth, xres,yres);
           
            BitmapData imgData = null;
            PixData pixData = null;
            try
            { 

                if ((img.PixelFormat & PixelFormat.Indexed) == PixelFormat.Indexed) {
                    CopyColormap(img, pix);
                }

                // transfer data
                imgData = img.LockBits(new Rectangle(0, 0, img.Width, img.Height), ImageLockMode.ReadOnly, img.PixelFormat);
                pixData = pix.GetData();

                if (imgData.PixelFormat == PixelFormat.Format32bppArgb) {
                    TransferDataFormat32bppArgb(imgData, pixData);
                } else if (imgData.PixelFormat == PixelFormat.Format24bppRgb) {
                    TransferDataFormat24bppRgb(imgData, pixData);
                } else if (imgData.PixelFormat == PixelFormat.Format8bppIndexed) {
                    TransferDataFormat8bppIndexed(imgData, pixData);
                } else if (imgData.PixelFormat == PixelFormat.Format1bppIndexed) {
                    TransferDataFormat1bppIndexed(imgData, pixData);
                }
                return pix;
            } catch (Exception) {
                pix.Dispose();
                throw;
            } finally {
                if (imgData != null) {
                    img.UnlockBits(imgData);
                }
            }
        }