Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PixConverter .NET Core support. #463

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

groogiam
Copy link

Allow PixConverter to be used by .NET Standard projects via the System.Drawing.Common nuget package.

@SimantoR
Copy link

Apart from the refactoring (which should've been done as a separate commit or PR) the System.Drawing seems needed.

@groogiam
Copy link
Author

So... does that mean you are not going to merge the pull request?

@mario-mestrovic
Copy link

@charlesw @groogiam Why is this not merged yet? It really just needs a System.Drawing.Common nuget package reference

@ArXen42
Copy link

ArXen42 commented Aug 13, 2019

Not sure whether it is possible to create pull request for pull request, so will just write it here. If this to be merged, NETFULL conditions should probably be removed from the following bitmap-related code too:

  • BitmapHelper.cs
  • ColorTests.cs
  • EngineTests.cs
  • LeptonicaPerfomanceTests.cs
  • TesseractEngine.cs

@YoungjaeKim
Copy link

YoungjaeKim commented Oct 18, 2019

For anyone in a hurry, use @groogiam's Tesseract_463 in nuget. It seems a forked version of this repo with PixConverter applied. I've migrated .Net 4.7 to Core 3.0 without any trouble with this.

Install-Package Tesseract_463 -Version 3.3.0.1

Note that the tessdata should be this; https://github.com/tesseract-ocr/tessdata/releases/tag/3.04.00

@charlesw
Copy link
Owner

charlesw commented Oct 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants