Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --all configurable globally #651

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

skatkov
Copy link
Contributor

@skatkov skatkov commented Sep 29, 2024

fixes #650

@bashbunni
Copy link
Member

Hey, I saw your issue and this change totally makes sense. We should probably mention this feature in the config section of the README. We should also add this field to the default config as well. Probably defaulting to all? I think that not being able to view files you would expect is more confusing than seeing these files and figuring out how to hide them

@skatkov
Copy link
Contributor Author

skatkov commented Sep 30, 2024

@bashbunni that's awesome suggestion!

@bashbunni
Copy link
Member

I just tweaked some things here - the all field was redundant as the showAllFiles field was already handling this behaviour. I added a default value of true to both the configuration file, and to the field itself in case it's unset anywhere. Tested that it works with both true and false values both in the config file and the args :)

@bashbunni
Copy link
Member

Let me know if it behaves as you'd expect, if so I can merge it :)

@skatkov
Copy link
Contributor Author

skatkov commented Sep 30, 2024

@bashbunni tested this locally, and it does work as expected!

@bashbunni bashbunni merged commit f1b5651 into charmbracelet:master Oct 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's surprising that markdown files that are .gitignor'ed are not shown by default (and slightly annoying)
2 participants