Hide Style Flags consistently #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
approved these changes
Nov 28, 2023
acidghost
reviewed
Nov 29, 2023
| @@ -74,7 +75,6 @@ func main() { | |||
| if errors.Is(err, exit.ErrAborted) { | |||
| os.Exit(exit.StatusAborted) | |||
| } | |||
| fmt.Println(err) | |||
There was a problem hiding this comment.
@maaslalani Why was this deleted? Now it's not printing any error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents style flags from leaking through when a user makes an error in the usage.
For example:
using the
--helpflag produces a different usage than the user making an error with the flags.This is because we perform the hiding of the flags on
BeforeResetwhich is called for the help flag but not on an error.The downside of this approach is that we must duplicate the style struct so that we can maintain a fully hidden embeddable struct while also having a non-hidden struct so the style command has proper usage / help / errors.
This can be resolve once the following issue is implemented:
alecthomas/kong#316