fix(confirm) --timeout
was ignored, now works as documented
#697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #698.
Relevant excerpts from
gum confirm --help
Changes
.WithTimeout(o.Timeout)
in theconfirm
command'shuh.NewForm()
chain underconfirm.Run()
errIsValidTimeout(error) bool
method toconfirm.Options
to facilitate safely ignoring the timeout error returned in the course of theRun()
context expiring due to timeouterrIsValidTimeout
Demos
Before: doesn't time out without outside help
Note that five seconds elapse here before
timeout
killsgum
, returning a nonzero exit code.After: times out as expected
Times out in ~1 second as desired.
Also works with
GUM_CONFIRM_TIMEOUT
.