bot will now notify participants who did not get matched #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bincyber
force-pushed
the
notify-member
branch
from
46fd519 to
3b94a8c
Compare
bincyber
force-pushed
the
notify-member
branch
from
3b94a8c to
e530d36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
This PR updates the bot to notify participants who did not get matched at the start of a new chat-roulette round.
In #34 the matching function was updated to a new version:
GetRandomMatchesV2(). This new version returns any members participating in chat-roulette who could not be matched. With users enabling the option to only be matched with others of the same gender, there is a higher likelihood of some members not getting a match. Therefore, it's vital that we notify participants who did not get matched instead of leaving them in the dark.👍 Definition of Done