Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-jira - Remove correlationID from frames options #30

Merged
merged 1 commit into from
May 22, 2024
Merged

no-jira - Remove correlationID from frames options #30

merged 1 commit into from
May 22, 2024

Conversation

precious-ossai-cko
Copy link
Contributor

Issue

NA

Proposed changes

  • Remove correlationID from frames options. It was noticed that when correlationID is passed to the cko ios log package, it causes a bug which makes the app to crash.

liam-smith-cko
liam-smith-cko previously approved these changes May 22, 2024
View reviewed changes
@precious-ossai-cko precious-ossai-cko force-pushed the no-jira-remove-correlation-id-from-frames-options branch from a802a80 to 2b281e3 Compare May 22, 2024 14:41
@precious-ossai-cko precious-ossai-cko merged commit b696c38 into main May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liam-smith-cko liam-smith-cko liam-smith-cko approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@precious-ossai-cko @liam-smith-cko