Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRISM-11343 - Wrap fingerprint implementation within a timeout #32

Conversation

precious-ossai-cko
Copy link
Contributor

Issue

https://checkout.atlassian.net/browse/PRISM-11343

Proposed changes

Wrap fingerprint implementation within a timeout

Test Steps

  1. On the fingerprintTimeoutInterval, change the timeoutInterval to 0.1.
  2. Use an example app to run the application, it should log the timeout error
  3. Revert the value after testing.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Reviewers assigned
  • I have performed a self-review of my code and manual testing
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if applicable)

Copy link
Collaborator

@okhan-okbay-cko okhan-okbay-cko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some unit tests around the newly added code please?

Sources/Risk/Risk.swift Outdated Show resolved Hide resolved
Copy link
Collaborator

@okhan-okbay-cko okhan-okbay-cko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@precious-ossai-cko precious-ossai-cko merged commit ac33d27 into main Jul 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants