Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add New Properties and Update Tests for Payments Processing #450

Merged

Conversation

armando-rodriguez-cko
Copy link
Contributor

feat: Add New Properties and Update Tests for Payments Processing

Description:

This PR introduces new properties to the payments processing module and enhances the test coverage to ensure accurate functionality and compliance with updated requirements.


Key Changes:

  1. New Properties in Payment Source and Processing Data:

    • RequestNetworkTokenSource:
      • Added StoreForFutureUse property for enhanced flexibility in tokenized payment management.
    • ProcessingData:
      • Introduced PanTypeProcessed to capture processed PAN type details.
      • Added CkoNetworkTokenAvailable to indicate the availability of a network token for the payment.
  2. Test Updates and Improvements:

    • Updated BankAccountFieldFormattingTest:
      • Marked test case as skipped ([Fact(Skip = "unavailable")]) to defer execution until required conditions are met.
    • Enhanced HostedPaymentsIntegrationTest:
      • Added DisplayName property in the hosted payment request to improve test realism.
    • Adjusted RequestApmPaymentsIntegrationTest:
      • Verified that payment response is correctly returned and added necessary assertions.

Impact:

  • Functionality:
    • New properties improve the flexibility and granularity of the payment process.
    • Better support for tokenized payments and advanced processing details.
  • Testing:
    • Ensures robust test coverage and accounts for new properties introduced.
  • Compatibility:
    • Updates align with modern payment processing requirements and API capabilities.

Testing:

  • All updated test cases have been executed successfully.
  • Skipped test cases have been deferred for future execution under specific conditions.

Notes:

  • Additional documentation may be required to guide users on the newly introduced properties.
  • Future improvements can include extending support for other network token-related configurations.

- Added ‘StoreForFutureUse’ to RequestNetworkTokenSource.
- Added ‘PanTypeProcessed’ and ‘CkoNetworkTokenAvailable’ to ProcessingData.
- Updated BankAccountFieldFormattingTest to skip unavailable test.
- Enhanced HostedPaymentsIntegrationTest with ‘DisplayName’ property.
- Refined RequestApmPaymentsIntegrationTest to include validation of payment response.`
@armando-rodriguez-cko armando-rodriguez-cko requested a review from a team January 24, 2025 13:23
@armando-rodriguez-cko armando-rodriguez-cko merged commit 55d2875 into master Jan 27, 2025
5 checks passed
@armando-rodriguez-cko armando-rodriguez-cko deleted the feature/INT-1540-INT-1541-previous-skip-tests branch January 27, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants