Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Frames 4.2.5 version #291

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Release: Frames 4.2.5 version #291

merged 2 commits into from
Jan 16, 2025

Conversation

chintan-soni-cko
Copy link
Contributor

@chintan-soni-cko chintan-soni-cko commented Jan 14, 2025

Issue

RELEASE-34799
Sub ticekts:PIMOB-3162
Fix for Tier 1 merchant: ticket

Proposed changes

Note

  1. Please review first this PR
  2. Slack conversion for this release it by early this week
    CC: @fabio-insolia-cko @jheng-hao-lin-cko

External release details:
[ADDED] - tokenFormat field in token response for Google Pay token

Test Steps

Follow release process here

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Reviewers assigned
  • I have performed a self-review of my code and manual testing
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if applicable)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered, etc...

@chintan-soni-cko chintan-soni-cko self-assigned this Jan 14, 2025
@chintan-soni-cko chintan-soni-cko force-pushed the feature/PIMOB-3162_add_token_format_field_for_gpay branch 2 times, most recently from c22b40f to 4e8f7b0 Compare January 14, 2025 14:20
@chintan-soni-cko chintan-soni-cko added the invalid This doesn't seem right label Jan 14, 2025
@chintan-soni-cko chintan-soni-cko changed the base branch from feature/PIMOB-3162_add_token_format_field_for_gpay to master January 14, 2025 17:46
@fabio-insolia-cko
Copy link
Contributor

@chintan-soni-cko please run
./gradlew :{module}:updateLintBaseline locally for each of the module that are failing the lint above so the CI will not fail

@chintan-soni-cko chintan-soni-cko removed the invalid This doesn't seem right label Jan 15, 2025
@chintan-soni-cko chintan-soni-cko marked this pull request as ready for review January 15, 2025 17:09
@chintan-soni-cko chintan-soni-cko requested a review from a team as a code owner January 15, 2025 17:09
@chintan-soni-cko chintan-soni-cko enabled auto-merge (squash) January 16, 2025 08:08
@chintan-soni-cko chintan-soni-cko merged commit b94f210 into master Jan 16, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants