Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify patch creation #791

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Simplify patch creation #791

merged 1 commit into from
Jan 7, 2025

Conversation

Bananeweizen
Copy link
Collaborator

@Bananeweizen Bananeweizen commented Dec 23, 2024

Revert most of aab8233. Instead of using a profile, just add <inherited>false</inherited> to the plugin which we don't want in the child modules.

Revert most of aab8233. Instead of
using a profile, just add <inherited>false</inherited> to the plugin
execution we don't want in the child modules.
@Bananeweizen Bananeweizen requested a review from rnveach December 28, 2024 18:55
@Calixte Calixte merged commit acc54ce into checkstyle:master Jan 7, 2025
7 checks passed
@romani
Copy link
Member

romani commented Jan 7, 2025

If patching validation causing problems and annoying.
Please create issues at https://github.com/checkstyle/patch-filters/issues

And disable/remove it from pom.
We don't have bandwidth to improve patch filters for now, but maybe be in future.

@Bananeweizen Bananeweizen deleted the patch branch January 8, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants