Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rubocop with cookstyle in lint #27

Closed
wants to merge 14 commits into from
Closed

Replace rubocop with cookstyle in lint #27

wants to merge 14 commits into from

Conversation

mattstratton
Copy link
Contributor

This change will execute cookstyle tests instead of rubocop in the lint phase, provided that cookstyle is installed on the builder/runner. If it is not, the rubocop functionality will occur instead.

Fixes #24

@mattstratton
Add cookstyle as default linter
3edd075 
Signed-off-by: Matt Stratton <[email protected]>
@mattstratton
Change return of rubocop
10dbba2 
Signed-off-by: Matt Stratton <[email protected]>
@mattstratton
Remove empty line
52b8f13 
Signed-off-by: Matt Stratton <[email protected]>
@mattstratton
Remove rubocop conditional
f352801 
This is just to test the cookstyle execution.

Signed-off-by: Matt Stratton <[email protected]>
@mattstratton
Remove rubocop conditional
4a112b8 
This is just to test the cookstyle execution.

Signed-off-by: Matt Stratton <[email protected]>
@mattstratton
Merge branch 'add-cookstyle' of github.com:mattstratton/delivery-truc…
c886ef5 
…k into add-cookstyle

Signed-off-by: Matt Stratton <[email protected]>

# Conflicts:
#	recipes/lint.rb
@mattstratton
Add live-stream
9b76c88 
Signed-off-by: Matt Stratton <[email protected]>
@mattstratton
Remove references to rubocop override
396ba15 
Signed-off-by: Matt Stratton <[email protected]>
@mattstratton
run cookstyle only if installed
5d51883 
Signed-off-by: Matt Stratton <[email protected]>
@mattstratton
Hardcode cookstyle check
526508a 
This is a debugging commit

Signed-off-by: Matt Stratton <[email protected]>
@mattstratton
Make cookstyle check for nil
da5bbb3 
Signed-off-by: Matt Stratton <[email protected]>
@mattstratton
Add guards around cookstyle
2efdcfa 
Signed-off-by: Matt Stratton <[email protected]>
@mattstratton
Cleanup to pass rubocop
67d450d 
Signed-off-by: Matt Stratton <[email protected]>
@mattstratton
Remove extra spaces in unchanged file
42572c5 
Signed-off-by: Matt Stratton <[email protected]>
@mattstratton
Copy link
Contributor Author

After further review, I realized that we need to have cookstyle be opt-in (at least for a while) since this change will cause a lot of people's pipelines to start failing (since they may not have been running rubocop already). I am going to close this PR, add the config capability, and will re-submit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattstratton