feat: two dimensions phase correction filter

[hamed-musallam]

No description provided.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	a890c91
Status:	✅  Deploy successful!
Preview URL:	https://82d49a14.nmrium.pages.dev
Branch Preview URL:	https://2d-phase-correction.nmrium.pages.dev

View logs

[lpatiny]

I play with it seems to me quite intuitive. 2D phasing is never an easy task. I could be merge now and we can add issues after.

I would prefer a toggle button rather that a drop down menu to select Vertical / Horizontal

You could use

and

This could be a group button rather than a toggle button so that user sees he can switch.

[lpatiny]

There is an issue because we need to apply on the 2D the phase correction at least before switching between axes.

We could try to apply the 2D phase correction on mouse up (once we finished phasing PH0 and PH1). Same is true when we edit the value directly.

[lpatiny]

Seems weird PH0 and PH1 do not change when I switch the direction.

Also when we switch from axes it the phase applied on the 2D ?

[hamed-musallam]

@lpatiny

When we change the pH values we apply them to the 2D. We debounce the applying on the 2D for 250 ms.

[lpatiny]

Debouncing is a good idea but if redrawing takes a long time it could still be problematic. We will see in the future if it is okay or if we should only recalculate when we release the pressed button on the button PH0 or PH1.