Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve main toolbar tooltip #3008

Merged
merged 15 commits into from
Apr 5, 2024
Merged

Conversation

hamed-musallam
Copy link
Member

@hamed-musallam hamed-musallam commented Apr 4, 2024

It's a sample. We'll discuss what to set there later.

Screenshot 2024-04-04 at 15 19 58
Screenshot 2024-04-04 at 15 20 06

@hamed-musallam hamed-musallam changed the title chore: update react-science to version 3.0.0 feat: improve main toolbar tooltip Apr 4, 2024
Copy link

cloudflare-workers-and-pages bot commented Apr 4, 2024

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: b6f37f0
Status: ✅  Deploy successful!
Preview URL: https://764dfaac.nmrium.pages.dev
Branch Preview URL: https://improve-main-toolbar-tooltip.nmrium.pages.dev

View logs

@hamed-musallam hamed-musallam force-pushed the improve-main-toolbar-tooltip branch from 410fdd9 to bf517de Compare April 4, 2024 10:26
@hamed-musallam hamed-musallam force-pushed the improve-main-toolbar-tooltip branch 4 times, most recently from aa62ff0 to df208f6 Compare April 4, 2024 13:33
@lpatiny
Copy link
Member

lpatiny commented Apr 4, 2024

Because the shortcuts only work with lowercase I think they should also be indicated there as lowercase

image

For zoon help: 3 possibilities (not 2):

  • Vertical zoom: scroll wheel
  • Horizontal zoom: shift + scroll wheel
  • Pan: right click

Remove 'Learn more' if there is currently no links to docs.nmrium.org

@hamed-musallam hamed-musallam force-pushed the improve-main-toolbar-tooltip branch from df208f6 to 453952d Compare April 4, 2024 14:36
@hamed-musallam hamed-musallam marked this pull request as ready for review April 5, 2024 07:56
@hamed-musallam hamed-musallam enabled auto-merge (squash) April 5, 2024 17:09
@hamed-musallam hamed-musallam merged commit dc5703c into main Apr 5, 2024
11 checks passed
@hamed-musallam hamed-musallam deleted the improve-main-toolbar-tooltip branch April 5, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants