fix nil pointer dereference in marshal binary of join cluster response …

…#15
chengshiwen · Jul 11, 2024 · 71cb30c · 71cb30c
1 parent 86054ea
commit 71cb30c
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/coordinator/rpc.go b/coordinator/rpc.go
@@ -1326,10 +1326,12 @@ type JoinClusterResponse struct {
 
 func (r *JoinClusterResponse) MarshalBinary() ([]byte, error) {
 	var pb internal.JoinClusterResponse
-	pb.Node = &internal.NodeInfo{
-		ID:      proto.Uint64(r.Node.ID),
-		Addr:    proto.String(r.Node.Addr),
-		TCPAddr: proto.String(r.Node.TCPAddr),
+	if r.Node != nil {
+		pb.Node = &internal.NodeInfo{
+			ID:      proto.Uint64(r.Node.ID),
+			Addr:    proto.String(r.Node.Addr),
+			TCPAddr: proto.String(r.Node.TCPAddr),
+		}
 	}
 	if r.Err != nil {
 		pb.Err = proto.String(r.Err.Error())