Treat Magisk versions newer than latest as supporting all features #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when patching with a Magisk version newer than the latest supported version and using --ignore-magisk-warnings, the upper bound of VER_PREINIT_DEVICE and VER_XZ_BACKUP would prevent those features from being used. It makes more sense to assume that a newer version supports all the same features as the latest supported version instead. Issue: #393 Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
added a commit
that referenced
this pull request
Dec 12, 2024
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when patching with a Magisk version newer than the latest supported version and using
--ignore-magisk-warnings, the upper bound ofVER_PREINIT_DEVICEandVER_XZ_BACKUPwould prevent those features from being used. It makes more sense to assume that a newer version supports all the same features as the latest supported version instead.Issue: #393