Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker support #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Docker support #20

wants to merge 1 commit into from

Conversation

pataquets
Copy link

@pataquets pataquets commented Mar 3, 2020

Add Dockerfile to enable image building. Useful for development and tests under Docker workflow.
Using the official Python 3 image, latest tag. More info at https://hub.docker.com/_/python/

Just adding files, setting working dir and running install and build instructions.

Build:

$ docker build -t dlnap .

Run:

$ docker run --rm -it dlnap [options...]

FYI, there's a still quicker to test, already built image on my Docker Hub. Test it by running:

$ docker run --rm -it pataquets/dlnap [options...]

Using --rm causes container it to be deleted after stop and -it makes the container not to go background and run interactively.

Optional improvement to come (maybe in another issue):

  • Create an 'official', based on your repo, automated build at Docker Hub for the image: https://docs.docker.com/docker-hub/builds/ . Just requires a free paid Docker Hub account and a following a quick 'Create automated build' process. I'll be happy to help on it, if needed.

@pataquets
Copy link
Author

@cherezov Do you have any feedback about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant