Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the base of a test framework #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adding the base of a test framework #4

wants to merge 4 commits into from

Conversation

MartinKondor
Copy link

Hy, I think it would be a great improvement for a11ygator to test it's functionalities.

I didn't find any tests here, so I made the base of a small framework in order to be able to test the most important parts.

Feel free to give advice, or to propose change.

Have a nice day!

@nicolocarpignoli nicolocarpignoli added the good first issue Good for newcomers label Jun 7, 2019
@nicolocarpignoli
Copy link
Member

Hi, thanks for your interest on a11ygator! 🐊
Please, can you also provide an example of a real test use case for a Browser extension?

@MartinKondor
Copy link
Author

Can be used like in 8dbe576

But I am concerned that a lot of functions are using the browser variable which is only available from an extension (or I miss something?), so I guess that later on the tests should be only available from the extension itself, like the source link now. It would be just a link somewhere in the popup, if there is a need for tests.

When I saw a11ygator's repository I was honestly surprised that this project doesn't have tests, so that's why I made this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants