-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #13 #25
base: development
Are you sure you want to change the base?
Closes #13 #25
Conversation
44b4567
to
9ed4ee5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Review requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The landing page doesn't fully implement the design on the task (mobile and tablet design are not present, the icon is not the same and the second button is not in the page)
- There are extra tags (empty
<style />
and/or<script />
) as well as extra indentation onLanding.vue
's template. I'm surprised eslint doesn't complain about it. - Feel free to remove the extra items generated by the scaffolding app. An example would be the logo or the
HelloWorld
component. App.vue
: We'll be using the router to change between pages, thus we need to render<router-view />
inside<v-content />
instead of individual components- caf9a87: Commit name should be descriptive. What does it do ?
Surprised I didn't see this. But a lot of what you are saying I don't understand. I skipped one of the buttons from the design, as it wasn't the final design and I didn't want to get carried away and opted for one. From my own end, it's very responsive |
As for the router, there is no router at the moment, so I didn't include it anywhere, surprised you said it's in the other files |
As for the empty script and styles, atm, nothing is being added there and it's something we should not worry about. Initial commit is basically the first commit I did, where I added Vuetify and did a little file structuring and naming |
|
Created Landing page following the mockup design provided
ref: #13