Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates frontend testing infrastructure, and adds a courses draft page #34

Merged
merged 17 commits into from
Jan 21, 2025

Conversation

brueningf
Copy link
Contributor

@brueningf brueningf commented Jan 20, 2025

This pull request includes changes to the backend and frontend configurations, scripts, and tests. The main improvements include adding mock data service to the frontend tests, generating types for from the prisma schema, and updating the frontend to fetch and display courses from the backend.

The testing infrastructure needs some work still, a possibility would be setting up a NPM workspace to join common libraries between backend, and framework. Scripts on the backend were added as a quick patch to make testing on the frontend easier.


<div className="flex justify-between mt-4">
<span className="text-sm text-gray-500">
{course?.instructor?.name}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be refactored since instructors are always a relationship. leave like this for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will change, but for now i added this commands to mock data, and populate the future staging database

@chingu-voyages chingu-voyages deleted a comment from netlify bot Jan 20, 2025
Copy link
Contributor

@ProgramStuff ProgramStuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ProgramStuff ProgramStuff merged commit e39f25d into chingu-voyages:staging Jan 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants