Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1.0 RTL with Lint Fixes #518

Open
wants to merge 30 commits into
base: patch_v1.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
4c9e86c
Issue 445 LINT fixes
Mar 1, 2024
fae37d0
Squashed commit of the following:
calebofearth Mar 28, 2024
c9f70d8
Regenerate RDL using updated peakrdl version
calebofearth Mar 30, 2024
bf9c45d
scrubbing enums in generated reg pkg files
Apr 1, 2024
cbd06f9
NVDA Lint Fixes on top of main_lint_regress branch
Mar 23, 2024
f7d608a
matching number of bits on RHS of AND mask equation
Apr 3, 2024
d7fdc94
Rename uses of keywords 'NULL', 'WAIT', 'Wait'
calebofearth Apr 3, 2024
53808f1
Cast address offset (constant) to addr_width for lint
calebofearth Apr 3, 2024
897ec57
Explicit types for localparams in VeeR
calebofearth Apr 4, 2024
cf4dde3
Change localparam types from 2-state to 4-state logic in csrng
calebofearth Apr 4, 2024
8f8db41
Add 'unsigned' qualifier
calebofearth Apr 4, 2024
592ae23
Convert more localparam int to localparam logic [31:0]
calebofearth Apr 4, 2024
fe4deaf
Change module params from 2-state to 4-state logic in csrng
calebofearth Apr 8, 2024
f4fc07b
Cast a 33-bit expression as 32-bit (drop the carry bit)
calebofearth Apr 8, 2024
48a829b
Cast literal constant as unsigned for lint
calebofearth Apr 8, 2024
76c4def
Reintegrate fix that should have been captured in the squash merge 20…
calebofearth Apr 9, 2024
095f6b0
rolling back change to modport to adhere to SV spec
Apr 9, 2024
35432e8
fix to dmi reg data width lint violation
Apr 25, 2024
4df4223
[entropy_src] Keep applying fw_ov_rd_fifo_overflow (#506)
moidx Apr 25, 2024
cf3b02d
[LINT] Resolving unnamed generate blocks Lint warnings (#510)
amullick007 May 3, 2024
3e7375d
Update HW_REV_ID to indicate v1.0.2
calebofearth May 17, 2024
f3a3306
Update README/Release_Notes for patch v1.0.2
calebofearth May 17, 2024
b87af3b
Fix for truncated bits after casting logical shifts to the incorrect …
calebofearth May 30, 2024
5e4a354
KeyVault fixes and JTAG fix (#528)
Nitsirks Jun 14, 2024
dc4154e
Fix for issue #523 - JTAG under reset during breakpoint (#541)
Nitsirks Jun 20, 2024
f280b02
Add recent fixes to release notes
calebofearth Jun 28, 2024
e8afaa8
Add smoke_test_hw_config (for HW_REV_ID) and update regression test l…
calebofearth Jul 22, 2024
9e7cef1
Update SCCACHE version in verilator workflows
calebofearth Jul 24, 2024
e2dc3e5
Revert SCCACHE to 0.3.3 version, use --locked flag to install
calebofearth Jul 29, 2024
aa6025f
Formatting - line breaks - in Release Notes
calebofearth Sep 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-test-verilator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Install sccache
if: steps.sccache_bin_restore.outputs.cache-hit != 'true'
run: |
cargo install sccache --version ${SCCACHE_VERSION} --no-default-features --features=gha
cargo install sccache --locked --version ${SCCACHE_VERSION} --no-default-features --features=gha
- name: Save sccache binary
uses: actions/cache/save@v3
if: steps.sccache_bin_restore.outputs.cache-hit != 'true'
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/interactive-debugging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:
env:
CARGO_INCREMENTAL: 0
SCCACHE_VERSION: 0.3.3
# TODO: To update to 5.006, clean up lint errors
VERILATOR_VERSION: v5.012
SCCACHE_GHA_CACHE_TO: sccache-verilator-10000
SCCACHE_GHA_CACHE_FROM: sccache-verilator-
Expand All @@ -35,7 +34,7 @@ jobs:
- name: Install sccache
if: steps.sccache_bin_restore.outputs.cache-hit != 'true'
run: |
cargo install sccache --version ${SCCACHE_VERSION} --no-default-features --features=gha
cargo install sccache --locked --version ${SCCACHE_VERSION} --no-default-features --features=gha

- name: Save sccache binary
uses: actions/cache/save@v3
Expand Down Expand Up @@ -115,7 +114,7 @@ jobs:
- name: Install sccache
if: steps.sccache_bin_restore.outputs.cache-hit != 'true'
run: |
cargo install sccache --version ${SCCACHE_VERSION} --no-default-features --features=gha
cargo install sccache --locked --version ${SCCACHE_VERSION} --no-default-features --features=gha

- name: Save sccache binary
uses: actions/cache/save@v3
Expand Down
12 changes: 11 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ See the License for the specific language governing permissions and<BR>
limitations under the License.*_<BR>

# **Caliptra Hands-On Guide** #
_*Last Update: 2024/01/17*_
_*Last Update: 2024/05/17*_


## **Tools Used** ##
Expand Down Expand Up @@ -51,6 +51,16 @@ GCC:
- G++ Used to compile Verilator objects and test firmware
- `g++ (GCC) 11.2.0`

RDL Compiler:
- systemrdl-compiler==1.27.3
- peakrdl-systemrdl==0.3.0
- peakrdl-regblock==0.21.0
- peakrdl-uvm==2.3.0
- peakrdl-ipxact==3.4.3
- peakrdl-html==2.10.1
- peakrdl-cheader==1.0.0
- peakrdl==1.1.0

Other:
- Playbook (Microsoft Internal workflow management tool)

Expand Down
45 changes: 39 additions & 6 deletions Release_Notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,46 @@ See the License for the specific language governing permissions and<BR>
limitations under the License.*_<BR>

# **Release Notes** #
_*Last Update: 2024/01/18*_
_*Last Update: 2024/06/28*_

## Rev 1p0 ##
### Rev 1p0p2 ###

### Rev 1p0 release date: 2024/01/18 ###
#### Rev 1p0p2 release date: 2024/06/28 ####
- Modifications for clean Lint
* Replace casez with case
* Replace 2-state with 4-state typedefs, parameters, enums
* Replace 'reg' with 'logic' type
* Radix fixes for many signals
* Logical/boolean operator fixes
* Logic reorganization to resolve undriven ICache signals in RV core
* Fixes for redundant logic in RV core
* Logically equivalent code adjustments to resolve potential index-out-of-bounds errors
* Declare synthesizable package functions as automatic
* Declare names for unnamed generate blocks
- Update PeakRDL tool version and regenerate reg files to resolve lint issues
- Update HW\_REV\_ID bit-map and configure value to 1.0.2

#### Bug Fixes ####
[ENTROPY\_SRC] Entropy source sfifo signal unable to exit reset #503 #506<br>
[PV] Async reset condition missing for `nonce_offset_i` #339 #444 #483<br>
[KV] Resolve a potential vulnerability in Key Vault usage #528<br>
[JTAG] VeeR JTAG access only with debug unlocked; Caliptra JTAG access with debug unlocked or manufacturing #528<br>
[JTAG] Enable JTAG interface to be used while boot FSM is halted at breakpoint #541<br>

## Previous Releases ##

### Rev 1p0p1 ###

#### Rev 1p0p1 release date: 2024/02/20 ####
- NOTE: v1.0.1 patch version was committed to the patch_v1.0 branch,
but no tag was created on GitHub and the HW_REV_ID field was not updated.

#### Bug Fixes ####
[RTL] Add connection for JTAG TDO enable signal #415 #425

### Rev 1p0 ###

#### Rev 1p0 release date: 2024/01/18 ####
- Caliptra Hardware Specification: Markdown conversion
- Caliptra Integration specification update with synthesis warnings and jtag tck requirement
- Caliptra README updates to clarify test cases and running with VCS
Expand All @@ -33,11 +68,9 @@ _*Last Update: 2024/01/18*_
- Remove TODO comments on caliptra_top ports
- Remove JTAG IDCODE command from RISC-V processor

### Bug Fixes ###
#### Bug Fixes ####
[MBOX] Fix ICCM Uncorrectable ECC error driving hw_error_non_fatal bit for LSU reads

## Previous Releases ##

### Rev 1p0-rc1 ###

#### Rev 1p0-rc1 release date: 2023/11/03 (1p0 version pending ROM release for official declaration) ###
Expand Down
Loading
Loading