[patch] Clarify cover string argument as comment not message. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
changed the title
This is different than the explanatory message argument on assert and assume statements.
dtzSiFive
force-pushed
the
feature/cover-comment-not-message
branch
from
e90ebc8
to
58b9779
Compare
dtzSiFive
changed the title
seldridge
approved these changes
Jan 21, 2023
seldridge
pushed a commit
that referenced
this pull request
Mar 2, 2023
This is different than the explanatory message argument on assert and assume statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak the existing field to match its use in practice (SFC), and planned to soon behave similarly in MFC: llvm/circt#4502 .
See #53 for discussion of this field, for now let's keep existing code working and update spec to reflect current behavior (and provide users a means to attach string information to the output that's not limited like
optional_name).