Don't assume string_view::iterator is const char* #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
force-pushed
the
feature-20250112-it-not-constchar
branch
3 times, most recently
from
b22cdbe to
7900a1e
Compare
hzeller
force-pushed
the
feature-20250112-it-not-constchar
branch
7 times, most recently
from
21e7cf3 to
4a45f97
Compare
hzeller
commented
Jan 13, 2025
| // TODO: find something platform independent that is less ugly. | ||
| // Or maybe revisit the place where we need this and see if they could | ||
| // be actually represented by a const char * nullptr. | ||
| inline absl::string_view::iterator string_view_null_iterator() { |
There was a problem hiding this comment.
this should probably in a different file; or in no file at all, just using absl::string_view::iterator{} everywhere (but that would then be less explicit).
There was a problem hiding this comment.
maybe place in common/strings?
There was a problem hiding this comment.
For now, I narrowed its use to anything that anyway uses format-token.h, so decided to leave it there for now.
(otherwise it would be a bit awkward to have a strings/null-iterator.h with a single inlined one-liner function in it...)
fangism
approved these changes
Jan 13, 2025
| // TODO: find something platform independent that is less ugly. | ||
| // Or maybe revisit the place where we need this and see if they could | ||
| // be actually represented by a const char * nullptr. | ||
| inline absl::string_view::iterator string_view_null_iterator() { |
There was a problem hiding this comment.
maybe place in common/strings?
hzeller
force-pushed
the
feature-20250112-it-not-constchar
branch
from
4a45f97 to
fbda6cc
Compare
There were a few assumptions in the code that these types are equivalent, but they are not on all platforms. The fixes sometimes involve ugly `&*some_iterator` constructs to get to the underlying location. Some of these should be re-considered after switching to c++20. We also have a `string_view_null_iterator()` function to generate an iterator that is not initialized to be used in place where we previously used comparison against nullptr. Issues: chipsalliance#2323
hzeller
force-pushed
the
feature-20250112-it-not-constchar
branch
from
fbda6cc to
ecc7bdc
Compare
hzeller
added a commit
to hzeller/verible
that referenced
this pull request
Jan 14, 2025
Now that we're compatible with all systems after PR chipsalliance#2324, can switch to use std::string_view now.
hzeller
added a commit
to hzeller/verible
that referenced
this pull request
Jan 14, 2025
Now that we're compatible with all systems after PR chipsalliance#2324, can switch to use std::string_view now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few assumptions in the code that these types are equivalent, but they are not on all platforms.
The fixes sometimes involve ugly
&*some_iteratorconstructs to get to the underlying location. Some of these should be re-considered after switching to c++20.Issues: #2323