Bugfix/task priority #151
Open
Bugfix/task priority #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
chirag-silabs
commented
Aug 27, 2024
chirag-silabs
commented
chirag-silabs
force-pushed
the
bugfix/platform_event_handling
branch
from
d7747ca to
02b2556
Compare
chirag-silabs
force-pushed
the
bugfix/task_priority
branch
from
0f91778 to
e33de46
Compare
chirag-silabs
changed the base branch from
bugfix/platform_event_handling
to
master
| break; | ||
|
|
||
| case DeviceEventType::kThreadConnectivityChange: | ||
| case DeviceEventType::kInternetConnectivityChange: { | ||
| #ifdef DIC_ENABLE | ||
| VerifyOrReturn(event->InternetConnectivityChange.IPv4 == kConnectivity_Established); |
There was a problem hiding this comment.
when DIC_ENABLE will be set to 1 this will cause the code to malfunction, better to replace with if in this case.
There was a problem hiding this comment.
Moved it at the end
| return RSI_ERROR_INVALID_PARAM; | ||
| } | ||
| wfx_rsi.drv_thread = osThreadNew(rsi_wireless_driver_task_wrapper, NULL, &kDrvTaskAttr); | ||
| // wfx_rsi.drv_task = xTaskCreateStatic((TaskFunction_t) rsi_wireless_driver_task, "rsi_drv", WFX_RSI_WLAN_TASK_SZ, NULL, |
| @@ -138,7 +138,12 @@ constexpr osThreadAttr_t kUartTaskAttr = { .name = "UART", | |||
| .cb_size = osThreadCbSize, | |||
| .stack_mem = uartStack, | |||
| .stack_size = kUartTaskSize, | |||
| .priority = osPriorityRealtime }; | |||
| #if SLI_SI91X_MCU_INTERFACE | |||
There was a problem hiding this comment.
leave a note as to why we are having different priority for 917 SoC
| /* Structure that will hold the TCB of the wfxRsi Task being created. */ | ||
| StaticTask_t wfxRsiTaskBuffer; | ||
| // Thread for the WLAN RSI | ||
| constexpr uint32_t kWlanTaskSize = 2048; |
There was a problem hiding this comment.
will it be better to keep all these in the wfx_rsi.h ? since we are keeping similar values there itself
| StackType_t wfxBLETaskStack[WFX_RSI_TASK_SZ] = { 0 }; | ||
| osTimerId_t sbleAdvTimeoutTimer; | ||
|
|
||
| constexpr uint32_t kBleTaskSize = 2048; |
There was a problem hiding this comment.
maybe shift to header file with a macro ?
senthilku
reviewed
Aug 30, 2024
| { | ||
| OTAConfig::Init(); | ||
| } | ||
| #endif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.