Added RO cities list

[rwkyyy]

This list is updated as of January 2021.

[YordanSoares]

Hello @rwkyyy,

Before adding this pull request to master, I want to ask you if it's OK to replace the special characters from the locations names, e.g. Balesti-Catun instead of Bălești-Cătun. If so, I'll merge your update.

[rwkyyy]

It's part of the language, that's how they are spelled.

[YordanSoares]

So, if I understand correctly, it's okay to replace the current names, with special characters like Bălești-Cătun, with the ones you proposed, like Balesti-Catun, right? I can't confirm this with anyone else in Romania, so I'm trusting what you tell me.

[rwkyyy]

No, you can not. It's considered lack of seriousness when not using them in a website.

[YordanSoares]

In such case I need to ask you to update the names with the correct characters, so I can proceed to merge your pull request.

[rwkyyy]

The reason why I submitted them in this format, is because I did not know if you have a filter for removing them; some shipping service providers do not recognize them correctly and this causes a issue for the end-use.r

[Killeros]

Great update.
@rwkyyy Maybe you could help me out with a issue regarding a old versions of this plugin.
I do have a 2017 version of this plugin that has been modified to autocomplete zipcodes to each city according to a list from a courier company ( GLS Romania ).
Using that plugin now, without any updates, makes my website run slow, as it has some errors since wordpress/woocommerce/php have updated.
My question: Would you mind having a look at the plugin ? It`s specially made for Romania.
But I am more interested in making a upgrade version of that plugin, that also autocompletes zipcodes, and benefits from up to date upgrades.

[rwkyyy]

@Killeros sure

[Killeros]

@Killeros sure

https://easyupload.io/88kgt2
This is my module. It works ok, with just the issue is that it makes my woocommerce slow, and if you check with query monitor, you will see that it has some errors.

Multumesc de ajutor.

[rwkyyy]

The main problem is the way the zip codes are loaded.

Base WC:

WC with official states & cities plugin:

WC with your modded plugin:

As you can notice from above, your mod reads the database with zip codes from a .xlsx file and this causes a big increase in processing time and memory; I would suggest you upgraded to latest version and either make a fork of the base plugin and add your zip-codes OR if you do not need the zip codes, you can just forget about them.

[rwkyyy]

@YordanSoares can you please add this or you need to patch the language diacritics?

[YordanSoares]

Hi @rwkyyy,

We are planning to resume the places merging very soon.

Is this PR still valid to merge?

[rwkyyy]

@YordanSoares from my knowledge yes, it should still be valid