🐛Apply sheetify and glslify after babelify #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#345 should be fixed by this. |
|
@yoshuawuyts Should be good now. Please take a look. Thanks! |
|
IIRC this was a potentially breaking change for some reason. I can check #choo chat logs later to see if it was mentioned why. We should do it though, but ideally without running sheetify and glslify as global transforms. We can remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like otherwise Babelify is applied after subject transforms.
This requires stackcss/sheetify#156 to be merged first in order to purifycss is able to cleanup transpiled templates code. @yoshuawuyts Please take a look at it.