Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#338) Fix systemd fact usage #339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(#338) Fix systemd fact usage #339

wants to merge 1 commit into from

Conversation

treydock
Copy link
Contributor

@treydock treydock commented Jan 7, 2025

The systemd fact is a boolean not a string so check if systemd == true.

Fixes #338

@treydock
(choria-io#338) Fix systemd fact usage
161e220 
The systemd fact is a boolean not a string so check if systemd == true.

Fixes choria-io#338
@smortex smortex added the bug label Jan 7, 2025
@smortex smortex mentioned this pull request Jan 7, 2025
Merged
@treydock
Copy link
Contributor Author

treydock commented Jan 7, 2025

@smortex Your other PR, it uses service_provider which I believe is stdlib. The fact systemd is part of systemd module. Maybe it's better to rely on stdlib instead of systemd module, ie someone without systemd may not have systemd module?

@treydock
Copy link
Contributor Author

treydock commented Jan 7, 2025

I'd be fine closing this in favor of your #340 PR.

@smortex
Copy link
Member

smortex commented Jan 7, 2025

I'd be fine closing this in favor of your #340 PR.

I am fine with both, but as you say this depend on the systemd module being present, so I re-opened #340. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix systemd fact usage
2 participants
@treydock @smortex