Merge pull request #48 from chris-mosley/fixFilterBypass

Fix filter bypass

package.json

@@ -1,7 +1,7 @@
 {
   "name": "AmazonBrandFilter",
   "description": "Filters out all unknown brands from Amazon search results.",
-  "version": "0.4.3",
+  "version": "0.5.0",
   "keywords": [],
   "author": "",
   "license": "MIT",

src/content/index.ts

@@ -8,32 +8,6 @@ import {
 import { getItemDivs, unHideDivs } from "utils/helpers";
 import { PopupMessage, StorageSettings } from "utils/types";
 
-const checkBrandFilter = (): boolean => {
-  const boxesdiv = document.getElementById("brandsRefinements")?.children;
-  if (!boxesdiv) {
-    return false;
-  }
-
-  let boxes: HTMLCollectionOf<HTMLInputElement> | undefined;
-  for (const div of boxesdiv) {
-    boxes = div.getElementsByTagName("input");
-    if (boxes.length > 0) {
-      break;
-    }
-  }
-
-  if (!boxes) {
-    return false;
-  }
-
-  for (const box of boxes) {
-    if (box.checked) {
-      return true;
-    }
-  }
-  return false;
-};
-
 const descriptionSearch = async (settings: StorageSettings, div: HTMLDivElement) => {
   const { syncSettings } = await getSettings();
 
@@ -164,9 +138,7 @@ const filterBrands = async (settings: StorageSettings) => {
   console.log("AmazonBrandFilter: Brands found");
 
   if (settings.refinerBypass) {
-    if (checkBrandFilter()) {
-      return;
-    }
+    return;
   }
 
   const divs = getItemDivs();
@@ -271,9 +243,11 @@ const listenForMessages = () => {
         break;
       case "refinerBypass":
         if (message.isChecked) {
-          if (checkBrandFilter()) {
-            return;
-          }
+          resetBrands();
+          // previously hidden elements should be shown
+          unHideDivs();
+        } else {
+          filterBrands(settings);
         }
         break;
       case "useDebugMode":