Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I noticed that MSVC's
<exception>
was unnecessarily dragging in<malloc.h>
, and attempted to remove it in microsoft/STL#4626. This revealed a lot of bugs in open-source projects, so I'll probably revert the change (at least for now). However, I thought I'd report this to you, since it's an easy fix.asio is using
_alloca
without including<malloc.h>
(the proper header as documented on Microsoft Learn), here:asio/asio/include/asio/detail/impl/socket_ops.ipp
Lines 2542 to 2543 in 12e0ce9
asio/asio/include/asio/detail/impl/socket_ops.ipp
Lines 2756 to 2758 in 12e0ce9
This usage is guarded by
#if defined(BOOST_NO_ANSI_APIS) || (defined(_MSC_VER) && (_MSC_VER >= 1800))
, but my proposed inclusion is guarded by only#if defined(_MSC_VER) && (_MSC_VER >= 1800)
since non-MSVCdefined(BOOST_NO_ANSI_APIS)
configurations are presumably getting_alloca
from somewhere else.