fix multiple statuses

christofdamian · Jan 5, 2016 · 9a9629e · 9a9629e
1 parent fb10294
commit 9a9629e
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,6 +1,10 @@
 CHANGES
 =======
 
+0.5.9
+-----
+* fix bug with multiple statuses
+
 0.5.8
 -----
 * allow leading whitespace

diff --git a/src/PlusPull/GitHub/PullRequest.php b/src/PlusPull/GitHub/PullRequest.php
@@ -64,10 +64,16 @@ public function getCommentValue($commentBody)
 
     public function checkStatuses()
     {
-        if (empty($this->statuses[0]['state'])) {
+        if (empty($this->statuses)) {
             return false;
         }
 
+        foreach ($this->statuses as $status) {
+            if (empty($status['state']) or $status['state']!='success') {
+                return false;
+            }
+        }
+
         return $this->statuses[0]['state']=='success';
     }
 

diff --git a/tests/PlusPull/GitHub/PullRequestTest.php b/tests/PlusPull/GitHub/PullRequestTest.php
@@ -215,6 +215,20 @@ public function checkStatusesProvider()
                 'statuses' => array(array('state' => 'error')),
                 'expected' => false,
             ),
+            'both, first error' => array(
+                'statuses' => array(
+                    array('state' => 'error'),
+                    array('state' => 'success'),
+                ),
+                'expected' => false,
+            ),
+            'both, first success' => array(
+                'statuses' => array(
+                    array('state' => 'success'),
+                    array('state' => 'error'),
+                ),
+                'expected' => false,
+            ),
         );
     }