Remove MarshalHelper

Not necessary anymore since .NET Core
chromiumboy · Jun 12, 2022 · 1e7956e · 1e7956e
1 parent 7655aec
commit 1e7956e
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 113 deletions.
diff --git a/OpenToolkit.GraphicsLibraryFramework/GLFW.cs b/OpenToolkit.GraphicsLibraryFramework/GLFW.cs
@@ -10,7 +10,6 @@
 using System;
 using System.Runtime.InteropServices;
 using static OpenToolkit.GraphicsLibraryFramework.GLFWNative;
-using static Robust.Shared.Utility.MarshalHelper;
 
 namespace OpenToolkit.GraphicsLibraryFramework
 {
@@ -211,7 +210,7 @@ public static unsafe void GetVersion(out int major, out int minor, out int revis
         /// <seealso cref="GetVersion"/>
         public static unsafe string GetVersionString()
         {
-            return PtrToStringUTF8(glfwGetVersionString());
+            return Marshal.PtrToStringUTF8((IntPtr) glfwGetVersionString());
         }
 
         /// <summary>
@@ -272,7 +271,7 @@ public static unsafe ErrorCode GetError(out string description)
         {
             byte* desc;
             var code = glfwGetError(&desc);
-            description = PtrToStringUTF8(desc);
+            description = Marshal.PtrToStringUTF8((IntPtr) desc);
             return code;
         }
 
@@ -590,7 +589,7 @@ public static unsafe void GetMonitorContentScaleRaw(Monitor* monitor, float* xSc
         /// </remarks>
         public static unsafe string GetMonitorName(Monitor* monitor)
         {
-            return PtrToStringUTF8(glfwGetMonitorName(monitor));
+            return Marshal.PtrToStringUTF8((IntPtr) glfwGetMonitorName(monitor));
         }
 
         /// <summary>
@@ -902,7 +901,7 @@ public static unsafe void SetGammaRamp(Monitor* monitor, GammaRamp* ramp)
         /// </remarks>
         public static unsafe void WindowHint(WindowHintString hint, string value)
         {
-            var ptr = StringToCoTaskMemUTF8(value);
+            var ptr = Marshal.StringToCoTaskMemUTF8(value);
 
             try
             {
@@ -1364,7 +1363,7 @@ public static bool RawMouseMotionSupported()
         /// </remarks>
         public static unsafe string GetKeyName(Keys key, int scanCode)
         {
-            return PtrToStringUTF8(glfwGetKeyName(key, scanCode));
+            return Marshal.PtrToStringUTF8((IntPtr) glfwGetKeyName(key, scanCode));
         }
 
         /// <summary>
@@ -2278,7 +2277,7 @@ public static unsafe JoystickHats[] GetJoystickHats(int jid)
         /// </remarks>
         public static unsafe string GetJoystickName(int jid)
         {
-            return PtrToStringUTF8(glfwGetJoystickName(jid));
+            return Marshal.PtrToStringUTF8((IntPtr) glfwGetJoystickName(jid));
         }
 
         /// <summary>
@@ -2351,7 +2350,7 @@ public static unsafe string GetJoystickName(int jid)
         /// </remarks>
         public static unsafe string GetJoystickGUID(int jid)
         {
-            return PtrToStringUTF8(glfwGetJoystickGUID(jid));
+            return Marshal.PtrToStringUTF8((IntPtr) glfwGetJoystickGUID(jid));
         }
 
         /// <summary>
@@ -2509,7 +2508,7 @@ public static bool JoystickIsGamepad(int jid)
         /// </remarks>
         public static unsafe bool UpdateGamepadMappings(string newMapping)
         {
-            var ptr = StringToCoTaskMemUTF8(newMapping);
+            var ptr = Marshal.StringToCoTaskMemUTF8(newMapping);
             try
             {
                 return glfwUpdateGamepadMappings((byte*)ptr) == GLFW_TRUE;
@@ -2585,7 +2584,7 @@ public static unsafe bool UpdateGamepadMappingsRaw(byte* newMapping)
         /// </remarks>
         public static unsafe string GetGamepadName(int jid)
         {
-            return PtrToStringUTF8(glfwGetGamepadName(jid));
+            return Marshal.PtrToStringUTF8((IntPtr) glfwGetGamepadName(jid));
         }
 
         /// <summary>
@@ -2854,7 +2853,7 @@ public static unsafe bool GetGamepadStateRaw(int jid, GamepadState* state)
         /// </remarks>
         public static unsafe bool ExtensionSupported(string extensionName)
         {
-            var ptr = StringToCoTaskMemUTF8(extensionName);
+            var ptr = Marshal.StringToCoTaskMemUTF8(extensionName);
 
             try
             {
@@ -2893,7 +2892,7 @@ public static unsafe bool ExtensionSupported(string extensionName)
         /// <seealso cref="ExtensionSupported" />
         public static unsafe IntPtr GetProcAddress(string procName)
         {
-            var ptr = StringToCoTaskMemUTF8(procName);
+            var ptr = Marshal.StringToCoTaskMemUTF8(procName);
 
             try
             {
@@ -3085,7 +3084,7 @@ public static unsafe bool ExtensionSupportedRaw(byte* extensionName)
         /// </remarks>
         public static unsafe Window* CreateWindow(int width, int height, string title, Monitor* monitor, Window* share)
         {
-            var ptr = StringToCoTaskMemUTF8(title);
+            var ptr = Marshal.StringToCoTaskMemUTF8(title);
 
             try
             {
@@ -3306,7 +3305,7 @@ public static unsafe bool ExtensionSupportedRaw(byte* extensionName)
         /// <seealso cref="SetClipboardString"/>
         public static unsafe string GetClipboardString(Window* window)
         {
-            return PtrToStringUTF8(glfwGetClipboardString(window));
+            return Marshal.PtrToStringUTF8((IntPtr) glfwGetClipboardString(window));
         }
 
         /// <summary>
@@ -3917,7 +3916,7 @@ public static unsafe IntPtr SetCharModsCallback(
         /// <seealso cref="GetClipboardString"/>
         public static unsafe void SetClipboardString(Window* window, string data)
         {
-            var ptr = StringToCoTaskMemUTF8(data);
+            var ptr = Marshal.StringToCoTaskMemUTF8(data);
 
             try
             {
@@ -4751,7 +4750,7 @@ public static unsafe void SetWindowShouldClose(Window* window, bool value)
         /// </remarks>
         public static unsafe void SetWindowTitle(Window* window, string title)
         {
-            var ptr = StringToCoTaskMemUTF8(title);
+            var ptr = Marshal.StringToCoTaskMemUTF8(title);
 
             try
             {
@@ -5340,7 +5339,7 @@ public static unsafe string[] GetRequiredInstanceExtensions()
             var array = new string[count];
             for (var i = 0; i < count; i++)
             {
-                array[i] = PtrToStringUTF8(ptr[i]);
+                array[i] = Marshal.PtrToStringUTF8((IntPtr) ptr[i]);
             }
 
             return array;
@@ -5386,7 +5385,7 @@ public static unsafe string[] GetRequiredInstanceExtensions()
         /// <returns>The address of the function, or <c>null</c> if an error occurred.</returns>
         public static unsafe IntPtr GetInstanceProcAddress(VkHandle instance, string procName)
         {
-            var ptr = StringToCoTaskMemUTF8(procName);
+            var ptr = Marshal.StringToCoTaskMemUTF8(procName);
 
             try
             {

diff --git a/OpenToolkit.GraphicsLibraryFramework/OpenToolkit.GraphicsLibraryFramework.csproj b/OpenToolkit.GraphicsLibraryFramework/OpenToolkit.GraphicsLibraryFramework.csproj
@@ -14,7 +14,4 @@
     <PackageReference Condition="'$(TargetFramework)' == 'net472'" Include="System.Memory" Version="4.5.3" />
   </ItemGroup>
 
-  <ItemGroup>
-    <ProjectReference Include="..\Robust.Shared\Robust.Shared.csproj" />
-  </ItemGroup>
 </Project>
diff --git a/Robust.Client/UserInterface/FileDialogManager.cs b/Robust.Client/UserInterface/FileDialogManager.cs
@@ -196,10 +196,10 @@ private static IntPtr FormatFiltersNfd(FileDialogFilters? filters)
             {
                 case sw_nfdresult.SW_NFD_ERROR:
                     var errPtr = sw_NFD_GetError();
-                    throw new Exception(MarshalHelper.PtrToStringUTF8(errPtr));
+                    throw new Exception(Marshal.PtrToStringUTF8((IntPtr) errPtr));
 
                 case sw_nfdresult.SW_NFD_OKAY:
-                    var str = MarshalHelper.PtrToStringUTF8(outPath)!;
+                    var str = Marshal.PtrToStringUTF8((IntPtr) outPath)!;
 
                     sw_NFD_Free(outPath);
                     return str;

diff --git a/Robust.Shared/Utility/MarshalHelper.cs b/Robust.Shared/Utility/MarshalHelper.cs
diff --git a/Robust.UnitTesting/Shared/Utility/MarshalHelper_Test.cs b/Robust.UnitTesting/Shared/Utility/MarshalHelper_Test.cs