-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write a test that global parsing doesn't conflict with local parsing #59
Comments
Hi, i want to take this one as my first task. I found a breaking case that is when the custom parser defines --no-input [TARGET] while being a mandatory option. Defined like this the app always displays the help/error message "expected: ...". I assume this is the second case of the listing above. |
@zetkez Feel free to give it a go! All CLI tests can be found in this module (and can be added here for now): I believe, it makes sense to test several combinations:
Once we have these 3 test cases, we can improve the documentation to reflect this behaviour 🙂 Hope that helps! |
Resolves #59 Co-authored-by: zetkez <[email protected]>
Similar to #56
People shouldn't specify options that conflict with ours. But if they still do, it would be nice to know whether their parsing conflicts with ours. So I propose to add two tests and document their results in public API:
my-program --no-input
when the custom parser specifies--no-input
as well (ideally this should be checked by Tests for CLI #13)my-program --no-input my-command --no-input
is confusing but ideally should be parsed and return different results for different--no-input
. If not, having a test is still good and documenting this behaviour is nice.The text was updated successfully, but these errors were encountered: