Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#59] add tests for catching global and local parser conflicts #88

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

zetkez
Copy link
Contributor

@zetkez zetkez commented Oct 10, 2022

Resolves #59

I added a few tests to demonstrate the conflicts between the local and global parser. The tests are by no means exhaustive, especially the tests using a optparse-applicative command. I put everything into the existing files and functions and now the code looks a bit crammed to me. Would it make sense to transfer it to a new file or at least create a new :: Spec function?
Also i did some tiny refactoring.

First time ever contributing to a Haskell project and feedback is much appreciated.

Additional tasks

  • Documentation for changes provided/changed
  • Tests added
  • Updated CHANGELOG.md

@zetkez zetkez requested a review from chshersh as a code owner October 10, 2022 12:42
@chshersh chshersh added test hacktoberfest-accepted https://hacktoberfest.com/participation/ labels Oct 10, 2022
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zetkez Thanks a lot for adding these tests!

I agree with the needed refactoring for this module but can't come up with a nice structure at the moment 🤔 Moving into a separate spec function would be a good first step though 👍🏻

Happy to merge the PR once this minor refactoring is done and conflicts with the main branch are resolved

@zetkez zetkez force-pushed the test_global_parsing_no_conflict_local branch from c4d5bec to 36328fe Compare October 12, 2022 15:20
@zetkez
Copy link
Contributor Author

zetkez commented Oct 12, 2022

@chshersh i moved the tests to its own spec function and moved the code down inside the file. I sadly managed to loose your review comments while doing a force push.

Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zetkez The refactoring looks great! Thanks a lot for improving the tests 👏🏻

The results are helpful and will definitely help to improve the documentation 🙂

@chshersh chshersh merged commit bb4f1b1 into chshersh:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted https://hacktoberfest.com/participation/ test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a test that global parsing doesn't conflict with local parsing
2 participants