-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set the HOME environment variable before invoking a command #32
feat: set the HOME environment variable before invoking a command #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for your contribution 💯
Two things left:
- Could you add a changelog
- The
HOME
code here can be simplifiedLines 22 to 27 in 311e035
let home_dir = Unix.getenv "HOME" in let login = Process.proc_stdout @@ Printf.sprintf "HOME=%s git config user.login" home_dir in if String.is_empty login then None else Some login
eb7b1eb
to
27e5560
Compare
|
27e5560
to
ff31212
Compare
ff31212
to
5337803
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks great!
BTW I forgot to mention that this PR indeed solves #26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
This should solve #26 where the global
.gitignore
file cannot be found.