Fix launch args for gazebo launch file #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Tiryoh
reviewed
Apr 16, 2023
There was a problem hiding this comment.
I have confirmed that this pull requset will also resolve issues related to odometry.
Excellent work, @CullenSUN!
mangdangroboticsclub/mini_pupper_ros#65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Champ_gazebo package has contact_sensor to publish feet contacts with ground in simulation.
The issue was champ_gazebo/launch/gazebo.launch.py used a hard coded links map file.
This fix is to use a launch argument so that we can pass in from outside launch files.
After fix:
mini_pupper_navi_ok.mp4