Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NuGet authentication #76

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

nilsatomada
Copy link

@nilsatomada nilsatomada commented Nov 26, 2024

adding the support for NuGet Authentication.

Authentication is configured through the following environment variables:

  • DEPC_NUGET_USERNAME => username for the authentication
  • DEPC_NUGET_PASSWORD => password for the authentication
  • DEPC_NUGET_SOURCESPREFIX => ability to filter which targets the credentials are associated with
  • DEPC_NUGET_VALID_AUTHENTICATION_TYPES => supported authentication types [ensuring that NuGet uses the right authentication format in the header]
  • DEPC_NUGET_PACKAGE_SOURCE_FILTER => filter out certain NuGet repositories from being added to the repositories used to analyze the dependencies

@nilsatomada
Copy link
Author

@chwebdude - new PR including the changes to support authentication for NuGet feeds / I think we'll have to improve the pipeline to not break with the versioning - I've removed the assigning of the current BuildNumber to the version for now just to see if the pipeline passes - Maybe only updating the patch number with a given Build Number is the better solution and we're taking the rest from the AssemblyInfo?

@nilsatomada nilsatomada marked this pull request as ready for review November 26, 2024 04:27
@chwebdude
Copy link
Owner

@nilsatomada Thanks for your contribution! But you don't need to touch the version information at all.
The ADO pipeline is querying the version from the Marketplace and is increasing the version automatically. Also the AssemblyVersion is updated during the build pipeline.

Therefore, can you update your PR so that there are no versioning changes?

@nilsatomada
Copy link
Author

@chwebdude done 👍 - thank you for considering it!

@nilsatomada
Copy link
Author

Hey @chwebdude - I think we'll have to change the way on how the version is being created in the pipeline - with the current BuildId we won't be able to update the AssemblyInfo.cs / do you want me to look into that?

@chwebdude
Copy link
Owner

chwebdude commented Nov 27, 2024

@nilsatomada

Hey @chwebdude - I think we'll have to change the way on how the version is being created in the pipeline - with the current BuildId we won't be able to update the AssemblyInfo.cs / do you want me to look into that?

Yes, I thought I already changed that by bypassing that with the condition: and(succeeded(), eq(variables['Build.Repository.Name'], 'chwebdude/DependencyChecker')), but apparently, the run from your Repo/PR is also considered as "my" Repo Name :(

If you have time, feel free to have a look into it. I'm quite busy this week, otherwise I will look into it next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants