Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Changed regex to include capital letters. #1877

Merged
merged 1 commit into from
Aug 1, 2023
Merged

fix: Changed regex to include capital letters. #1877

merged 1 commit into from
Aug 1, 2023

Conversation

rahulk789
Copy link
Contributor

Fixes #1871

Helm validates capital letters during name check of clusters. Extended the same for cilium cli.

@rahulk789 rahulk789 requested a review from a team as a code owner July 28, 2023 05:29
@rahulk789 rahulk789 requested a review from derailed July 28, 2023 05:29
@rahulk789 rahulk789 temporarily deployed to ci July 28, 2023 05:29 — with GitHub Actions Inactive
@michi-covalent michi-covalent merged commit 0528377 into cilium:main Aug 1, 2023
19 checks passed
@ZhongRuoyu ZhongRuoyu mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asauber asauber asauber approved these changes

@derailed derailed Awaiting requested review from derailed derailed is a code owner automatically assigned from cilium/cli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forced to change k8s cluster name as per regex.
3 participants
@rahulk789 @asauber @michi-covalent